faxrunqd uses getopts.pl

[Andreas Barth]

Hi,

I received a bugreport that faxrunqd uses getops.pl, whereas modern
perl should use Getopt::Long or Getopt::Std.

Gert, what's your opinion on that? Do you want to take Getopt::* in
mgetty?


Andi


----- Forwarded message from Dominic Hargreaves <***@earth.li> -----

From: Dominic Hargreaves <***@earth.li>
Reply-To: Dominic Hargreaves <***@earth.li>, ***@bugs.debian.org
To: ***@bugs.debian.org
Subject: Bug#659425: mgetty-fax: Uses perl4 corelibs without Depends
Date: Fri, 10 Feb 2012 23:50:10 +0000

Package: mgetty-fax
Version: 1.1.36-1.6
Severity: normal
User: debian-***@lists.debian.org
Usertags: perl4-corelibs

Dear maintainer,

This package currently uses one or more deprecated perl 4 era packages,
as shown on the lintian report[1]:

usr/sbin/faxrunqd:102 getopts.pl

As detailed at [2] we would like you to either add a dependency on

libperl4-corelibs-perl | perl (<< 5.12.3-7)

or (ideally) to replace their use with more modern equivalents.
We'd like to have this in place for wheezy, so that we can follow
cleanly the upstream deprecation cycle in wheezy+1.

If you prefer, I will NMU your package with the dependency added.

The wiki page [2] has references (taken from the source of the libraries
in question) for the recommended replacement libraries.

Thanks,
Dominic.

[1] <http://lintian.debian.org/tags/script-uses-perl4-libs-without-dep.html>
[2] <http://wiki.debian.org/Teams/DebianPerlGroup/OpenTasks/Transitions/Perl4CoreLibs>

[Gert Doering]

Hi,

Post by Andreas Barth
I received a bugreport that faxrunqd uses getops.pl, whereas modern
perl should use Getopt::Long or Getopt::Std.
Gert, what's your opinion on that? Do you want to take Getopt::* in
mgetty?

I was young and didn't know better :-)

Now, changing this to Getopt::Std is 10 minutes work, and I'm happy to
do so. OTOH, getting a new release of mgetty out of the door is more
work (and I have a few pending changes that need to go in).

So what's easier for you? Backport the patch (faxrunqd has changed
a bit since 1.1.37, so the patch might need a bit of adaption), or wait
for the next release?

gert

[Gert Doering]

Hi,

Post by Gert Doering

Post by Andreas Barth
I received a bugreport that faxrunqd uses getops.pl, whereas modern
perl should use Getopt::Long or Getopt::Std.
Gert, what's your opinion on that? Do you want to take Getopt::* in
mgetty?

I was young and didn't know better :-)

Uh.

Now *how* old exactly is the mgetty version in Debian...?

faxrunqd's CVS history lists...

# Revision 1.58 2002/03/19 12:20:45 gert
# change from deprecated "require 'getopts.pl'" to "use Getopt::Std"

gert

[Debian Bug Tracking System]

Thank you for the additional information you have supplied regarding
this Bug report.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
Andreas Barth <***@not.so.argh.org>

If you wish to submit further information on this problem, please
send it to ***@bugs.debian.org.

Please do not send mail to ***@bugs.debian.org unless you wish
to report a problem with the Bug-tracking system.

[Gert Doering]

Hi,

Post by Debian Bug Tracking System
Thank you for the additional information you have supplied regarding
this Bug report.

... sorry for that. I should really take "reply-to considered harmful"
to heart.

My mgetty list mails have "Reply-To: ***@muc.de", because I usually
do not want discussion mails to go to me personally, but to the list - but
when talking to robots, this leads to "robot mails go to the list as
well", and that's not wanted.

gert

[Andreas Barth]

Post by Gert Doering
Hi,

Post by Gert Doering

Post by Andreas Barth
I received a bugreport that faxrunqd uses getops.pl, whereas modern
perl should use Getopt::Long or Getopt::Std.
Gert, what's your opinion on that? Do you want to take Getopt::* in
mgetty?

I was young and didn't know better :-)

Uh.
Now *how* old exactly is the mgetty version in Debian...?
faxrunqd's CVS history lists...
# Revision 1.58 2002/03/19 12:20:45 gert
# change from deprecated "require 'getopts.pl'" to "use Getopt::Std"

Make that my fault for not checking the bugreport before forwarding it
to you.

Sorry, I assumed the perl team to be right when reporting the bug.

Closing the bug now, it's a false positive.


Andi

[Debian Bug Tracking System]

Thank you for the additional information you have supplied regarding
this Bug report.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
Andreas Barth <***@not.so.argh.org>

If you wish to submit further information on this problem, please
send it to ***@bugs.debian.org.

Please do not send mail to ***@bugs.debian.org unless you wish
to report a problem with the Bug-tracking system.

[Gert Doering]

Hi,

Make that my fault for not checking the bugreport before forwarding it
to you.
Sorry, I assumed the perl team to be right when reporting the bug.

Heh, it would have been a good occasion to do a new mgetty release :))

gert

[Andreas Barth]

Post by Gert Doering
Hi,

Make that my fault for not checking the bugreport before forwarding it
to you.
Sorry, I assumed the perl team to be right when reporting the bug.

Heh, it would have been a good occasion to do a new mgetty release :))

I should do a cleanup upload anyways, but ... ;)



Andi

[Gert Doering]

Hi,

Post by Andreas Barth
This package currently uses one or more deprecated perl 4 era packages,
usr/sbin/faxrunqd:102 getopts.pl

Nothing better than automated source code "analysis" tools that just
grep for certain strings, and nobody that actually looks at the output...

Most likely, this is the CVS Log entry:

# Revision 1.58 2002/03/19 12:20:45 gert
# change from deprecated "require 'getopts.pl'" to "use Getopt::Std"

(which is now in line 142, but could have been line 102 in 1.1.36)

Can someone teach this tool what a comment looks like, please?

gert

[Debian Bug Tracking System]

Thank you for the additional information you have supplied regarding
this Bug report.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
Andreas Barth <***@not.so.argh.org>

If you wish to submit further information on this problem, please
send it to ***@bugs.debian.org.

Please do not send mail to ***@bugs.debian.org unless you wish
to report a problem with the Bug-tracking system.